Re: meson PGXS compatibility

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-hackers(at)postgresql(dot)org, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Subject: Re: meson PGXS compatibility
Date: 2022-10-05 21:10:22
Message-ID: 20221005211022.n3u3unn6ibfszjma@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-10-05 16:58:46 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > My understanding, from that commit message, was that the issue originates in
> > apple's ranlib setting the timestamp to its components but only queries / sets
> > it using second granularity. I verified that apple's ranlib and ar these days
> > just set the current time, at a high granularity, as the mtime. Whether or
> > not make then hides the problem seems not that relevant if the source of the
> > problem is gone, no?
>
> Well, (a) it seemed to happen in only some circumstances even back then,
> so maybe your testing didn't catch it; and (b) even assuming that Apple
> has fixed it in recent releases, there may still be people using older,
> un-fixed versions. Why's it such a problem to keep the "touch" step?

It isn't! That's why I said that I was on the fence about removing the touch
in my first email and then that I'd leave the touch there and just
s/ranlib/ar/ in my reply to you.

Greetings,

Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Runqi Tian 2022-10-05 21:17:07 Testing DDL Deparser
Previous Message Bruce Momjian 2022-10-05 21:00:03 Re: An attempt to avoid locally-committed-but-not-replicated-to-standby-transactions in synchronous replication