From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Dagfinn Ilmari Mannsåker <ilmari(at)ilmari(dot)org> |
Cc: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Add meson.build to version_stamp.pl |
Date: | 2022-10-05 18:20:50 |
Message-ID: | 20221005182050.5ygpvquvjj77xug6@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2022-10-05 11:36:36 +0100, Dagfinn Ilmari Mannsåker wrote:
> Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
>
> > Thinking ahead a bit, we need to add meson.build to version_stamp.pl.
Good idea. I was wondering for a moment whether we should put the version
into some file instead, and reference that from meson.build - but the
convenient way to do that is only in 0.56, which we currently don't want to
require... We could work around it, but it doesn't seem necessary for now.
> > Maybe someone can think of a better sed expression, but this one seems
> > good enough to me for now.
> […]
> > +sed_file("meson.build",
> > + qq{-e "1,20s/ version: '[0-9a-z.]*',/ version: '$fullversion',/"}
> > +);
>
> I think it would be better to not rely on the line numbers, but instead
> limit it to the project() stanza, something like this:
> sed_file("meson.build",
> qq{-e "/^project(/,/^)/ s/ version: '[0-9a-z.]*',/ version: '$fullversion',/"}
> );
Yea, that looks nicer.
Greetings,
Andres Freund
From | Date | Subject | |
---|---|---|---|
Next Message | Nathan Bossart | 2022-10-05 18:57:16 | Re: archive modules |
Previous Message | Nathan Bossart | 2022-10-05 18:08:09 | Re: Suppressing useless wakeups in walreceiver |