Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: bharath(dot)rupireddyforpostgres(at)gmail(dot)com
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Use XLogFromFileName() in pg_resetwal to parse position from WAL file
Date: 2022-10-04 06:41:30
Message-ID: 20221004.154130.81110075358497671.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Tue, 04 Oct 2022 15:23:48 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> This is not directly related to this patch, pg_resetwal.c has the
> following line..
>
> > static uint32 minXlogTli = 0;

I have found other three instances of this in xlog.c and
pg_receivewal.c. Do they worth fixing?

(pg_upgarade.c has "uint32 tli/logid/segno but I'm not sure they need
to be "fixed". At least the segno is not a XLogSegNo.)

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2022-10-04 06:48:49 Re: GUC tables - use designated initializers
Previous Message Peter Eisentraut 2022-10-04 06:30:32 Re: Convert macros to static inline functions