Re: How to retain lesser paths at add_path()?

From: Andres Freund <andres(at)anarazel(dot)de>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Nils Dijk <me(at)thanod(dot)nl>
Cc: Jaime Casanova <jcasanov(at)systemguards(dot)com(dot)ec>, Kohei KaiGai <kaigai(at)heterodb(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: How to retain lesser paths at add_path()?
Date: 2022-10-02 16:59:24
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers


On 2022-07-31 16:05:20 -0400, Tom Lane wrote:
> Thoughts?

As the patch got some feedback ~2 months ago, I'm updating the status to

Minor note: cfbot complains about a cpluspluscheck violation:

[12:24:50.124] time make -s cpluspluscheck EXTRAFLAGS='-fmax-errors=10'
[12:25:17.757] In file included from /tmp/cpluspluscheck.AoEDdi/test.cpp:3:
[12:25:17.757] /tmp/cirrus-ci-build/src/include/optimizer/pathnode.h: In function ‘PathComparison path_comparison_combine(PathComparison, PathComparison)’:
[12:25:17.757] /tmp/cirrus-ci-build/src/include/optimizer/pathnode.h:39:19: error: invalid conversion from ‘int’ to ‘PathComparison’ [-fpermissive]
[12:25:17.757] 39 | return (c1 | c2) & PATH_COMPARISON_MASK;
[12:25:17.757] | ^
[12:25:17.757] | |
[12:25:17.757] | int
[12:25:33.857] make: *** [GNUmakefile:141: cpluspluscheck] Error 1


Andres Freund

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-10-02 17:02:37 Re: Improve TAP tests of pg_upgrade for cross-version tests
Previous Message Andres Freund 2022-10-02 16:55:03 Re: Proposal for internal Numeric to Uint64 conversion function.