From: | Andres Freund <andres(at)anarazel(dot)de> |
---|---|
To: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, John Naylor <john(dot)naylor(at)enterprisedb(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Erik Rijkers <er(at)xs4all(dot)nl>, Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Stephen Frost <sfrost(at)snowman(dot)net>, Surafel Temesgen <surafel3000(at)gmail(dot)com>, vignesh C <vignesh21(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: proposal: possibility to read dumped table's name from file |
Date: | 2022-10-02 16:04:13 |
Message-ID: | 20221002160413.x7stjt2bdvnjvra3@awork3.anarazel.de |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Hi,
On 2022-10-02 00:19:59 -0700, Andres Freund wrote:
> On 2022-10-01 23:56:59 -0700, Andres Freund wrote:
> > On 2022-09-12 09:58:37 +0200, Daniel Gustafsson wrote:
> > > Correct, fixed in the attached.
> >
> > Updated patch adding meson compatibility attached.
>
> Err, forgot to amend one hunk :(
That fixed it on all platforms but windows, due to copy-pasto. I really should
have stopped earlier yesterday...
> +/*-------------------------------------------------------------------------
> + *
> + * filter.h
> + * Common header file for the parser of filter file
> + *
> + * Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
> + * Portions Copyright (c) 1994, Regents of the University of California
> + *
> + * src/bin/pg_dump/filter.h
> + *
> + *-------------------------------------------------------------------------
> + */
> +#ifndef FILTER_H
> +#define FILTER_H
> +#include "c.h"
c.h (and postgres.h, postgres_fe.h) shouldn't be included in headers.
This is a common enough mistake that I'm wondering if we could automate
warning about it somehow.
Greetings,
Andres Freund
Attachment | Content-Type | Size |
---|---|---|
v7-0001-Add-include-exclude-filtering-via-file-in-pg_dump.patch | text/x-diff | 30.7 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jonathan S. Katz | 2022-10-02 16:36:52 | Re: Question: test "aggregates" failed in 32-bit machine |
Previous Message | Andres Freund | 2022-10-02 15:46:43 | Re: pg_upgrade test failure |