Re: pgstattuple: add test for coverage

From: Andres Freund <andres(at)anarazel(dot)de>
To: Dong Wook Lee <sh95119(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: pgstattuple: add test for coverage
Date: 2022-10-02 07:14:30
Message-ID: 20221002071430.xfurt6znk2ruyxwy@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-08-03 11:19:59 +0900, Dong Wook Lee wrote:
> Is there no problem with selecting all the columns during SELECT statements?
> I thought there might be a problem where the test results could change easily.

Which indeed is the case, e.g. on 32bit systems it fails:

https://cirrus-ci.com/task/4619535222308864?logs=test_world_32#L253

https://api.cirrus-ci.com/v1/artifact/task/4619535222308864/testrun/build-32/testrun/pgstattuple/regress/regression.diffs

table_len | tuple_count | tuple_len | tuple_percent | dead_tuple_count | dead_tuple_len | dead_tuple_percent | free_space | free_percent
-----------+-------------+-----------+---------------+------------------+----------------+--------------------+------------+--------------
- 1171456 | 5000 | 560000 | 47.8 | 5000 | 560000 | 47.8 | 7452 | 0.64
+ 1138688 | 5000 | 540000 | 47.42 | 5000 | 540000 | 47.42 | 14796 | 1.3
(1 row)

...

You definitely can't rely on such details not to change across platforms.

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2022-10-02 07:16:36 Re: Transparent column encryption
Previous Message Andres Freund 2022-10-02 07:12:30 Re: Amcheck verification of GiST and GIN