| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | bt22nakamorit(at)oss(dot)nttdata(dot)com |
| Cc: | torikoshia(at)oss(dot)nttdata(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Make ON_ERROR_STOP stop on shell script failure |
| Date: | 2022-09-29 04:51:09 |
| Message-ID: | 20220929.135109.686813839550314879.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 29 Sep 2022 12:35:04 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> > Thank you for the feedback!
> > I agree that the messages should be more clear.
> > \\!: command was not executed
> > \\!: command failed
> > Would these two messages be enough to describe the two cases?
>
> FWIW, I would spell these as something like this:
>
> > \\!: command execution failure: %m
The following might be more complient to our policy.
> \\!: failed to execute command \"%s\": %m
> > \\!: command returned failure status: %d
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Masahiko Sawada | 2022-09-29 04:52:47 | Re: [PATCH] Log details for client certificate failures |
| Previous Message | Amit Langote | 2022-09-29 04:46:54 | Re: Eliminating SPI from RI triggers - take 2 |