| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Aleksander Alekseev <aleksander(at)timescale(dot)com> |
| Cc: | PostgreSQL Development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Refactor UnpinBuffer() |
| Date: | 2022-09-28 21:08:28 |
| Message-ID: | 20220928210828.GA3303@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Sep 28, 2022 at 08:14:23PM +0300, Aleksander Alekseev wrote:
> + ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
> +
> /* not moving as we're likely deleting it soon anyway */
> ref = GetPrivateRefCountEntry(b, false);
> Assert(ref != NULL);
> -
> - if (fixOwner)
> - ResourceOwnerForgetBuffer(CurrentResourceOwner, b);
Is it safe to move the call to ResourceOwnerForgetBuffer() to before the
call to GetPrivateRefCountEntry()? From my quick skim of the code, it
seems like it should be safe, but I thought I'd ask the question.
Otherwise, LGTM.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Thomas Munro | 2022-09-28 22:53:02 | Re: making relfilenodes 56 bits |
| Previous Message | Robert Haas | 2022-09-28 21:05:53 | problems with making relfilenodes 56-bits |