Re: Enables to call Unregister*XactCallback() in Call*XactCallback()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Hao Wu <gfphoenix78(at)gmail(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Enables to call Unregister*XactCallback() in Call*XactCallback()
Date: 2022-09-26 22:13:39
Message-ID: 20220926221339.GA1344127@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Mon, Sep 26, 2022 at 06:05:34PM -0400, Tom Lane wrote:
> Yeah. Whether it's efficient or not, seems like it should *work*.
> I'm a bit inclined to call this a bug-fix and backpatch it.
>
> I went looking for other occurrences of this code in places that have
> an unregister function, and found one in ResourceOwnerReleaseInternal,
> so I think we should fix that too. Also, a comment seems advisable;
> that leads me to the attached v2.

LGTM. I have no opinion on back-patching.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message David Rowley 2022-09-26 22:28:46 Re: Reducing the chunk header sizes on all memory context types
Previous Message Tom Lane 2022-09-26 22:05:34 Re: Enables to call Unregister*XactCallback() in Call*XactCallback()