| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pryzby(at)telsasoft(dot)com |
| Cc: | michael(at)paquier(dot)xyz, andres(at)anarazel(dot)de, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: fix stats_fetch_consistency value in postgresql.conf.sample |
| Date: | 2022-09-26 08:29:58 |
| Message-ID: | 20220926.172958.1790193605025533956.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Sat, 17 Sep 2022 23:53:07 -0500, Justin Pryzby <pryzby(at)telsasoft(dot)com> wrote in
> This is an alternative implementation, which still relies on adding the
> GUC_DYNAMIC, flag but doesn't require adding a new, sql-accessible
> function to convert the GUC to a pretty/human display value.
Thanks!
I'm not sure shared_buffer is GUC_DYNAMIC_DEFAULT, and we need to read
postgresql.conf.sample using SQL, but +1 for the direction.
+ AND NOT (sc.sample_value ~ '^0' AND current_setting(name) ~ '^0') -- zeros may be written differently
+ AND NOT (sc.sample_value='60s' AND current_setting(name) = '1min') -- two ways to write 1min
Mmm. Couldn't we get away from that explicit exceptions?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-09-26 08:33:12 | Re: A doubt about a newly added errdetail |
| Previous Message | kuroda.hayato@fujitsu.com | 2022-09-26 08:27:55 | RE: Perform streaming logical transactions by background workers and parallel apply |