Re: pg_stat_statements and "IN" conditions

From: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
To: Sergei Kornilov <sk(at)zsrv(dot)org>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Zhihong Yu <zyu(at)yugabyte(dot)com>, David Steele <david(at)pgmasters(dot)net>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Greg Stark <stark(at)mit(dot)edu>, Pavel Trukhanov <pavel(dot)trukhanov(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Subject: Re: pg_stat_statements and "IN" conditions
Date: 2022-09-24 14:07:14
Message-ID: 20220924140714.irgoytcu2wacdl2i@ddolgov.remote.csb
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

> On Fri, Sep 16, 2022 at 09:25:13PM +0300, Sergei Kornilov wrote:
> Hello!
> Unfortunately the patch needs another rebase due to the recent split of guc.c (0a20ff54f5e66158930d5328f89f087d4e9ab400)
> I'm reviewing a patch on top of a previous commit and noticed a failed test:
> # Failed test 'no parameters missing from postgresql.conf.sample'
> # at t/ line 82.
> # got: '1'
> # expected: '0'
> # Looks like you failed 1 test of 3.
> t/ ..............
> The new option has not been added to the postgresql.conf.sample
> PS: I would also like to have such a feature. It's hard to increase pg_stat_statements.max or lose some entries just because some ORM sends requests with a different number of parameters.

Thanks! I'll post the rebased version soon.

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Noah Misch 2022-09-24 17:20:20 Re: tweak to a few index tests to hits ambuildempty() routine.
Previous Message Nikita Malakhov 2022-09-24 12:50:24 Re: Pluggable toaster