| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
| Cc: | bt22kawamotok <bt22kawamotok(at)oss(dot)nttdata(dot)com>, Shinya Kato <Shinya11(dot)Kato(at)oss(dot)nttdata(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: [PATCH]Feature improvement for MERGE tab completion |
| Date: | 2022-09-20 15:51:05 |
| Message-ID: | 20220920155105.y7rb57pb5fpoxmln@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Sep-18, Fujii Masao wrote:
> The tab-completion code for MERGE was added in the middle of that for LOCK TABLE.
> This would be an oversight of the commit that originally supported tab-completion
> for MERGE. I fixed this issue.
Argh, thanks.
> "MERGE" was tab-completed with just after "EXPLAIN" or "EXPLAIN ANALYZE", etc.
> Since "INTO" always follows "MERGE", it's better to complete with "MERGE INTO"
> there. I replaced "MERGE" with "MERGE INTO" in those tab-completions.
OK, that would be similar to REFRESH MATERIALIZED VIEW.
The rules starting at line 4111 make me a bit nervous, since nowhere
we're restricting them to operating only on MERGE lines. I don't think
it's a real problem since USING is not terribly common anyway. Likewise
for the ones with WHEN [NOT] MATCHED. I kinda wish we had a way to
search for stuff like "keyword MERGE appears earlier in the command",
but we don't have that.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I'm always right, but sometimes I'm more right than other times."
(Linus Torvalds)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-20 16:15:13 | Re: Tree-walker callbacks vs -Wdeprecated-non-prototype |
| Previous Message | Alvaro Herrera | 2022-09-20 15:28:57 | Re: Proposal to use JSON for Postgres Parser format |