| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, samay sharma <smilingsamay(at)gmail(dot)com>, Nazir Bilal Yavuz <byavuz81(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [RFC] building postgres with meson - v13 |
| Date: | 2022-09-17 16:58:49 |
| Message-ID: | 20220917165849.6gb6af5lq3nm4qcr@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-09-16 16:22:35 -0400, Tom Lane wrote:
> Andres Freund <andres(at)anarazel(dot)de> writes:
> > On 2022-09-16 09:14:20 +1200, Thomas Munro wrote:
> >> On Thu, Sep 15, 2022 at 2:26 PM Andres Freund <andres(at)anarazel(dot)de> wrote:
> >>> - noticed that libpgport.a had and needed a dependency on errcodes.h - that
> >>> seemed wrong. The dependency is due to src/port/*p{read,write}v?.c including
> >>> postgres.h - which seems wrong. So I added a patch changing them to include
> >>> c.h.
>
> >> Oops. +1
>
> > Looks like this has been the case since
> > 0d56acfbaa799553c0c6ea350fd6e68d81025994 in 14. Any opinions on whether we
> > should backpatch the "fix"?
>
> +1, those files have no business including all of postgres.h
Done.
I've been wondering whether we should protect against this kind of issue on
the buildsystem level. Whenever building frontend code, add something like
-DBUILDING_FRONTEND, and error out if postgres.h is included without going
through postgres_fe.h.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Julien Rouhaud | 2022-09-17 17:06:12 | Re: Allow file inclusion in pg_hba and pg_ident files |
| Previous Message | Michael Banck | 2022-09-17 16:57:39 | Re: [EXTERNAL] Re: Support load balancing in libpq |