| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | japinli(at)hotmail(dot)com |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Typo in xact.c |
| Date: | 2022-09-16 03:11:35 |
| Message-ID: | 20220916.121135.398256374890151741.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
At Thu, 15 Sep 2022 22:38:01 +0800, Japin Li <japinli(at)hotmail(dot)com> wrote in
>
> Hi hacker,
>
> Recently, I find there might be a typo in xact.c comments. The comments
> say "PG_PROC", however, it actually means "PGPROC" structure. Since we
> have pg_proc catalog, and use PG_PROC to reference the catalog [1], so,
> we should use PGPROC to reference the structure. Any thoughts?
>
> [1] src/include/nodes/primnodes.h
The patch seems to me covering all occurances of PG_PROC as PGPROC.
I found several uses of PG_PROC as (pg_catalog.)pg_proc, which is
quite confusing, too..
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Justin Pryzby | 2022-09-16 03:19:01 | Re: Background writer and checkpointer in crash recovery |
| Previous Message | John Naylor | 2022-09-16 02:48:03 | Re: Inconsistencies in error messages |