| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Michael Paquier <michael(at)paquier(dot)xyz>, Robert Haas <robertmhaas(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: postgres_fdw hint messages |
| Date: | 2022-09-13 19:02:55 |
| Message-ID: | 20220913190255.GA2973985@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Sep 13, 2022 at 08:32:43AM +0200, Peter Eisentraut wrote:
> I notice that for column misspellings, the hint is phrased "Perhaps you
> meant X." whereas here we have "Did you mean X?". Let's make that uniform.
Good point. I attached a new version of the patch that uses the column
phrasing. I wasn't sure whether "reference" was the right word to use in
this context, but I used it for now for consistency with the column hints.
I think "specify" or "use" would work as well.
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Adjust-assorted-hint-messages-that-list-all-valid.patch | text/x-diff | 16.8 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-09-13 21:01:33 | Re: wrong shell trap |
| Previous Message | Alvaro Herrera | 2022-09-13 18:10:02 | wrong shell trap |