Re: [PATCH] Fix alter subscription concurrency errors

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Jelte Fennema <Jelte(dot)Fennema(at)microsoft(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [PATCH] Fix alter subscription concurrency errors
Date: 2022-09-09 16:37:07
Message-ID: 20220909163707.7lf2li2hj3urmzx4@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Aug-26, Jelte Fennema wrote:

> I indeed don't think this problem is unique to subscriptions, but it seems
> better to at least have this problem in a few places less (not making perfect
> the enemy of good).
>
> If someone has a more generic way of solving this for other commands too,
> then that sounds great, but if not then slowly chipping away at these cases
> seems better than keeping the status quo.
>
> Attached is a new patch where ALTER SUBSCRIPTION ... OWNER TO ... can
> now also be executed concurrently with the other subscription commands.

Would it work to use get_object_address() instead? That would save
having to write a lookup-and-lock function with a retry loop for each
object type.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Stephen Frost 2022-09-09 16:40:04 Re: Add tracking of backend memory allocated to pg_stat_activity
Previous Message Stephen Frost 2022-09-09 16:34:15 Re: Add tracking of backend memory allocated to pg_stat_activity