Re: [BUG] wrong FK constraint name when colliding name on ATTACH

On 2022-Sep-09, Amit Langote wrote:

> Yes, the loop in GetForeignKeyActionTriggers() needs this:
>
> + /* Only ever look at "action" triggers on the PK side. */
> + if (RI_FKey_trigger_type(trgform->tgfoid) != RI_TRIGGER_PK)
> + continue;
>
> Likewise, GetForeignKeyActionTriggers() needs this:
>
> + /* Only ever look at "check" triggers on the FK side. */
> + if (RI_FKey_trigger_type(trgform->tgfoid) != RI_TRIGGER_FK)
> + continue;
>
> We evidently missed this in f4566345cf40b0.

Ouch. Thank you, pushed.

> On Fri, Sep 9, 2022 at 4:54 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:

> > I'd counsel dropping the early-exit optimization; it doesn't
> > save much I expect, and it evidently hides bugs. Or maybe
> > make it conditional on !USE_ASSERT_CHECKING.
>
> While neither of these functions are called in hot paths, I am
> inclined to keep the early-exit bit in non-assert builds.

I kept it that way.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/
"El hombre nunca sabe de lo que es capaz hasta que lo intenta" (C. Dickens)