| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> |
| Cc: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE |
| Date: | 2022-09-07 09:17:49 |
| Message-ID: | 20220907091749.GY31833@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On Wed, Sep 07, 2022 at 11:11:37AM +0200, Peter Eisentraut wrote:
> On 06.09.22 08:27, Michael Paquier wrote:
> > On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote:
> > > Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com> writes:
> > > > I think renumbering this makes sense. We could just leave the comment
> > > > as is if we don't come up with a better wording.
> > >
> > > +1, I see no need to change the comment. We just need to establish
> > > the precedent that values within the GUC_UNIT_MEMORY field can be
> > > chosen sequentially.
> >
> > +1.
>
> committed without the comment change
Thank you
| From | Date | Subject | |
|---|---|---|---|
| Next Message | David Rowley | 2022-09-07 12:20:53 | pgsql: Make MemoryContextContains work correctly again |
| Previous Message | Christoph Berg | 2022-09-07 09:15:08 | Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Amit Langote | 2022-09-07 09:23:06 | Re: ExecRTCheckPerms() and many prunable partitions |
| Previous Message | Christoph Berg | 2022-09-07 09:15:08 | Re: [postgis-devel] PostGIS and json_categorize_type (Re: pgsql: Revert SQL/JSON features) |