Re: pgsql: Add ALTER SUBSCRIPTION ... SKIP.

On 2022-Mar-22, Amit Kapila wrote:

> Add ALTER SUBSCRIPTION ... SKIP.

There are two messages here that seem oddly worded.

msgid "start skipping logical replication transaction finished at %X/%X"
msgid "done skipping logical replication transaction finished at %X/%X"

Two complaints here. First, the phrases "start / finished" and "done /
finished" look very strange. It took me a while to realize that
"finished" refers to the LSN, not to the skipping operation. Do we ever
talk about a transaction "finished at XYZ" as opposed to a transaction
whose LSN is XYZ? (This became particularly strange when I realized
that the LSN might come from a PREPARE.)

Second, "logical replication transaction". Is it not a regular
transaction that we happen to be processing via logical replication?

I think they should say something like

"logical replication starts skipping transaction with LSN %X/%X"
"logical replication completed skipping transaction with LSN %X/%X"

Other ideas?

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
Officer Krupke, what are we to do?
Gee, officer Krupke, Krup you! (West Side Story, "Gee, Officer Krupke")