Re: postgres_fdw hint messages

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Haas <robertmhaas(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: postgres_fdw hint messages
Date: 2022-09-01 22:31:28
Message-ID: 20220901223128.GA932597@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

On Fri, Aug 26, 2022 at 12:35:38PM -0400, Tom Lane wrote:
> Peter also mentioned the possibility of "did you mean" with a closest
> match offered. That seems like a reasonable idea if someone
> is motivated to create the code, which I'm not.
> I vote for just dropping all these hints for now, while leaving the
> door open for anyone who wants to write closest-match-offering code.

Here is a quickly-hacked-together proof-of-concept for using Levenshtein
distances to determine which option to include in the hint. Would
something like this suffice? If so, I will work on polishing it up a bit.

Nathan Bossart
Amazon Web Services:

Attachment Content-Type Size
did_you_mean.patch text/x-diff 12.3 KB

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Junwang Zhao 2022-09-01 23:08:44 Re: [PATCH v1] fix potential memory leak in untransformRelOptions
Previous Message Andres Freund 2022-09-01 22:25:45 Re: Allow logical replication to copy tables in binary format