| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>, Michael Paquier <michael(at)paquier(dot)xyz>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |
| Date: | 2022-08-31 19:24:28 |
| Message-ID: | 20220831192428.GA641777@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Wed, Aug 31, 2022 at 12:14:33PM -0700, Andres Freund wrote:
> On 2022-08-27 14:06:32 +0530, Bharath Rupireddy wrote:
>> - if (lstat(fromfile, &fst) < 0)
>> - ereport(ERROR,
>> - (errcode_for_file_access(),
>> - errmsg("could not stat file \"%s\": %m", fromfile)));
>> + xlde_type = get_dirent_type(fromfile, xlde, false, ERROR);
>>
>> - if (S_ISDIR(fst.st_mode))
>> + if (xlde_type == PGFILETYPE_DIR)
>> {
>> /* recurse to handle subdirectories */
>> if (recurse)
>> copydir(fromfile, tofile, true);
>> }
>> - else if (S_ISREG(fst.st_mode))
>> + else if (xlde_type == PGFILETYPE_REG)
>> copy_file(fromfile, tofile);
>> }
>> FreeDir(xldir);
>
> It continues to make no sense to me to add behaviour changes around
> error-handling as part of a conversion to get_dirent_type(). I don't at all
> understand why e.g. the above change to make copydir() silently skip over
> files it can't stat is ok?
In this example, the call to get_dirent_type() should ERROR if the call to
lstat() fails (the "elevel" argument is set to ERROR).
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-08-31 19:26:57 | Re: pg_stat_have_stats() returns true for dropped indexes (or for index creation transaction rolled back) |
| Previous Message | Bruce Momjian | 2022-08-31 19:17:57 | Re: Tracking last scan time |