Re: pgsql: Fix broken cast on MSVC

From: Julien Rouhaud <rjuju123(at)gmail(dot)com>
To: John Naylor <john(dot)naylor(at)postgresql(dot)org>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Fix broken cast on MSVC
Date: 2022-08-30 02:26:36
Message-ID: 20220830022636.qrcbcecmhztbxrwa@jrouhaud
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Hi,

On Mon, Aug 29, 2022 at 10:45:43AM +0000, John Naylor wrote:
>
> +/*
> + * Exactly like vector32_is_highbit_set except for the input type, so it
> + * looks at each byte separately.
> + *
> + * [...]
> + */
> +#ifndef USE_NO_SIMD
> +static inline bool
> +vector32_is_highbit_set(const Vector32 v)
> [...]

Shouldn't the comment be "Exactly like vector8_is_highbit_set..."?

Also, is there any reason to not have a function prototype for this one? As
far as I can see that's the only one that doesn't in simd.h.

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message David Rowley 2022-08-30 02:38:12 pgsql: Use MAXALIGN() in calculations using sizeof(SlabBlock)
Previous Message Michael Paquier 2022-08-30 00:53:24 pgsql: Cleanup more code and comments related to Windows NT4 (XP days)