Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com>
Cc: Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Andres Freund <andres(at)anarazel(dot)de>, "Bossart, Nathan" <bossartn(at)amazon(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work
Date: 2022-08-23 18:07:44
Message-ID: 20220823180744.GD1207981@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Wed, Aug 17, 2022 at 12:39:26PM +0530, Bharath Rupireddy wrote:
> + /*
> + * We're only handling directories here, skip if it's not ours. Also, skip
> + * if the caller has already performed this check.
> + */
> + if (!slot_dir_checked &&
> + lstat(path, &statbuf) == 0 && !S_ISDIR(statbuf.st_mode))
> return;

There was previous discussion about removing this stanza from
ReorderBufferCleanupSeralizedTXNs() completely [0]. If that is still
possible, I think I would choose that over having callers specify whether
to do the directory check.

> + /* we're only handling directories here, skip if it's not one */
> + sprintf(path, "pg_replslot/%s", logical_de->d_name);
> + if (get_dirent_type(path, logical_de, false, LOG) != PGFILETYPE_DIR)
> + continue;

IIUC an error in get_dirent_type() could cause slots to be skipped here,
which is a behavior change.

[0] https://postgr.es/m/20220329224832.GA560657%40nathanxps13

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Alvaro Herrera 2022-08-23 18:10:03 Re: handling multiple matching constraints in DetachPartitionFinalize()
Previous Message Tom Lane 2022-08-23 18:00:13 Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition)