From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
---|---|
To: | Bharath Rupireddy <bharath(dot)rupireddyforpostgres(at)gmail(dot)com> |
Cc: | Michael Paquier <michael(at)paquier(dot)xyz>, Andres Freund <andres(at)anarazel(dot)de>, Cary Huang <cary(dot)huang(at)highgo(dot)ca>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
Subject: | Re: add checkpoint stats of snapshot and mapping files of pg_logical dir |
Date: | 2022-08-23 17:49:40 |
Message-ID: | 20220823174940.GC1207981@nathanxps13 |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On Wed, Aug 17, 2022 at 11:17:24AM +0530, Bharath Rupireddy wrote:
> + "logical decoding file(s) processing time=%ld.%03d s",
I would suggest shortening this to something like "logical decoding
processing" or "logical replication processing."
> CheckPointRelationMap();
> CheckPointReplicationSlots();
> +
> + CheckpointStats.l_dec_ops_start_t = GetCurrentTimestamp();
> CheckPointSnapBuild();
> CheckPointLogicalRewriteHeap();
> + CheckpointStats.l_dec_ops_end_t = GetCurrentTimestamp();
> +
> CheckPointReplicationOrigin();
Shouldn't we include CheckPointReplicationSlots() and
CheckPointReplicationOrigin() in this new stat?
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
From | Date | Subject | |
---|---|---|---|
Next Message | Alvaro Herrera | 2022-08-23 17:50:59 | Re: [BUG] parenting a PK constraint to a self-FK one (Was: Self FK oddity when attaching a partition) |
Previous Message | Tom Lane | 2022-08-23 17:47:40 | Re: archive modules |