| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: tests and meson - test names and file locations |
| Date: | 2022-08-11 15:06:34 |
| Message-ID: | 20220811150634.i236t6jkk4zuyocl@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-11 10:20:42 -0400, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
> > I also like that. I think we should take this opportunity for some
> > serious rationalization of this. Tests and associated data have grown
> > rather like Topsy, and we should fix that. So please don't feel too
> > constrained by current practice.
>
> I'm definitely -1 on that. Major rearrangement of the test scripts
> would be a huge blocking factor for almost any back-patch. I don't
> care much if you want to rearrange how the tests are invoked, but
> please don't touch the individual .sql and .pl scripts.
I don't precisely know what Andrew was thinking of, but the relocation of log
files for example doesn't require many changes to .pl files - one change to
Utils.pm. The one exception to that is 010_tab_completion.pl, which encodes
tmp_check/ in its output.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-08-11 15:20:28 | Re: pg_upgrade test writes to source directory |
| Previous Message | Tom Lane | 2022-08-11 14:52:51 | Re: Cleaning up historical portability baggage |