| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | Greg Stark <stark(at)mit(dot)edu> |
| Cc: | "Drouvot, Bertrand" <bdrouvot(at)amazon(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Melanie Plageman <melanieplageman(at)gmail(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Justin Pryzby <pryzby(at)telsasoft(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: shared-memory based stats collector - v70 |
| Date: | 2022-08-10 22:26:25 |
| Message-ID: | 20220810222625.g7gilqhj5pyhlvyi@awork3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-08-10 15:48:15 -0400, Greg Stark wrote:
> One thing that's bugging me is that the names we use for these stats
> are *all* over the place.
Yes. I had a huge issue with this when polishing the patch. And Horiguchi-san
did as well. I had to limit the amount of cleanup done to make it feasible to
get anything committed. I think it's a bit less bad than before, but by no
means good.
> * The pg_stat_bgwriter view returns data from two different fixed
> entries, the checkpointer and the bgwriter, is there a reason those
> are kept separately but then reported as if they're one thing?
Historical raisins. Checkpointer and bgwriter used to be one thing, but isn't
anymore.
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Nathan Bossart | 2022-08-10 22:31:20 | Re: use SSE2 for is_valid_ascii |
| Previous Message | Andres Freund | 2022-08-10 22:23:27 | Re: shared-memory based stats collector - v70 |