| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net>, David Steele <david(at)pgmasters(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: moving basebackup code to its own directory |
| Date: | 2022-08-09 18:40:16 |
| Message-ID: | 20220809184016.GE19644@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Tue, Aug 09, 2022 at 01:32:49PM -0400, Robert Haas wrote:
> On Tue, Aug 9, 2022 at 12:43 PM Magnus Hagander <magnus(at)hagander(dot)net> wrote:
> >> > So maybe src/backend/backup? Or is that too grandiose for the amount
> >> > of stuff we have here?
> >>
> >> +1 for src/backend/backup. I'd also be happy to see the start/stop code
> >> move here at some point.
> >
> > Yeah, sounds reasonable. There's never an optimal source code layout, but I agree this one is better than putting it under replication.
>
> OK, here's a patch.
It looks like this updates the header comments in the .h files but not the .c
files.
Personally, I find these to be silly boilerplate ..
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-08-09 18:44:10 | Re: Reducing the chunk header sizes on all memory context types |
| Previous Message | Nathan Bossart | 2022-08-09 18:38:24 | Re: Avoid erroring out when unable to remove or parse logical rewrite files to save checkpoint work |