Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking
Date: 2022-08-05 16:10:43
Message-ID: 20220805161043.nsbxv565k4q453no@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2022-Aug-05, Alvaro Herrera wrote:

> Add a test that tickles the case, as branch testing technology allows.

One point here is that this confirms that the backpatched renaming alias
for PostgreSQL::Test::Cluster is working well.

Another is that, as far as I know, this is the going to be the only case
of any code being run under wal_consistency_checking=[not off]
regularly. 027_stream_regress.pl is equipped to do so, but as far as I
know we have no buildfarm animal with PG_EXTRA_TESTS set it so. I did
consider to make this new test conditional on having that flag be on,
but I disregarded it because of that.

A third point is that in branches 15+ I made it use pg_walinspect to
ensure that the desired WAL record is being emitted.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-08-05 16:46:58 pgsql: Fix incorrect permissions-checking code for extended statistics.
Previous Message Alvaro Herrera 2022-08-05 16:04:43 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Geoghegan 2022-08-05 17:13:41 Re: BTMaxItemSize seems to be subtly incorrect
Previous Message Alvaro Herrera 2022-08-05 16:04:43 pgsql: BRIN: mask BRIN_EVACUATE_PAGE for WAL consistency checking