Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: amit(dot)kapila16(at)gmail(dot)com
Cc: sawada(dot)mshk(at)gmail(dot)com, shiy(dot)fnst(at)fujitsu(dot)com, bdrouvot(at)amazon(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org, minsoo(at)amazon(dot)com
Subject: Re: [BUG] Logical replication failure "ERROR: could not map filenode "base/13237/442428" to relation OID" with catalog modifying txns
Date: 2022-08-03 06:27:53
Message-ID: 20220803.152753.1366568723713736969.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Wed, 3 Aug 2022 08:51:40 +0530, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote in
> On Wed, Aug 3, 2022 at 7:05 AM Masahiko Sawada <sawada(dot)mshk(at)gmail(dot)com> wrote:
> > Looking at other codes in snapbuild.c, we call CloseTransientFile()
> > before erroring out in SnapBuildSerialize(). I think it's better to
> > keep it consistent with nearby codes in this patch. I think if we
> > prefer the style of closing the file by ereport(ERROR), it should be
> > done for all of them in a separate patch.
> >
>
> +1. I also feel it is better to change it in a separate patch as this
> is not a pattern introduced by this patch.

Agreed.

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Dilip Kumar 2022-08-03 06:30:16 Re: [Proposal] Fully WAL logged CREATE DATABASE - No Checkpoints
Previous Message Kyotaro Horiguchi 2022-08-03 06:25:32 Re: collate not support Unicode Variation Selector