| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Amit Langote <amitlangote09(at)gmail(dot)com> |
| Cc: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>, Simon Riggs <simon(dot)riggs(at)enterprisedb(dot)com> |
| Subject: | Re: enable/disable broken for statement triggers on partitioned tables |
| Date: | 2022-08-01 18:58:08 |
| Message-ID: | 20220801185808.hw7o5pgsiktgdw2n@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Aug-01, Amit Langote wrote:
> On Sat, Jul 30, 2022 at 5:25 AM Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
> > I do not think it's a great idea to have ALTER TABLE scribbling on
> > the source parsetree.
>
> Hmm, I think we already do scribble on the source parse tree even
> before this patch, for example, as ATPrepCmd() does for DROP
> CONSTRAINT:
>
> if (recurse)
> cmd->subtype = AT_DropConstraintRecurse;
No, actually nothing scribbles on the parsetree, because ATPrepCmd is
working on a copy of the node, so there's no harm done to the original.
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I can't go to a restaurant and order food because I keep looking at the
fonts on the menu. Five minutes later I realize that it's also talking
about food" (Donald Knuth)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-08-01 19:13:22 | Re: enable/disable broken for statement triggers on partitioned tables |
| Previous Message | Naeem Akhter | 2022-08-01 18:28:54 | Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row |