pg_upgrade errno

From: Justin Pryzby <pryzby(at)telsasoft(dot)com>
To: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: pg_upgrade errno
Date: 2022-07-31 13:41:35
Message-ID: 20220731134135.GY15006@telsasoft.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Since 3a769d823 (pg_upgrade: Allow use of file cloning)
file.c has had:

- if (ioctl(dest_fd, FICLONE, src_fd) < 0)
- {
- unlink(dst);
- pg_fatal("error while cloning relation \"%s.%s\" (\"%s\" to \"%s\"): %s",
- schemaName, relName, src, dst, strerror(errno));
- }

But errno should be saved before strerror/%m.

--
Justin

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message mahendrakar s 2022-07-31 15:05:58 Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory
Previous Message Hamid Akhtar 2022-07-31 13:18:16 Re: Allow pageinspect's bt_page_stats function to return a set of rows instead of a single row