| From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Dilip Kumar <dilipbalaut(at)gmail(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, Heikki Linnakangas <hlinnaka(at)iki(dot)fi>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, vignesh C <vignesh21(at)gmail(dot)com> |
| Subject: | Re: making relfilenodes 56 bits |
| Date: | 2022-07-29 19:18:18 |
| Message-ID: | 20220729191818.s5ygny5uhkdkf2fb@alvherre.pgsql |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2022-Jul-29, Robert Haas wrote:
> Yeah, if we think it's OK to pass around structs, then that seems like
> the right solution. Otherwise functions that take RelFileLocator
> should be changed to take const RelFileLocator * and we should adjust
> elsewhere accordingly.
We do that in other places. See get_object_address() for another
example. Now, I don't see *why* they do it. I suppose there's
notational convenience; for get_object_address() I think it'd be uglier
with another out argument (it already has *relp). For smgropen() it's
not clear at all that there is any.
For the new function, there's at least a couple of places that the
calling convention makes simpler, so I don't see why you wouldn't use it
that way.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Use it up, wear it out, make it do, or do without"
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-29 19:44:25 | Re: Inconvenience of pg_read_binary_file() |
| Previous Message | Tomas Vondra | 2022-07-29 19:16:51 | Re: Oversight in slab.c SlabContextCreate(), initial memory allocation size is not populated to context->mem_allocated |