Re: standby recovery fails (tablespace related) (tentative patch and discussion)

On 2022-Jul-22, Kyotaro Horiguchi wrote:

> At Fri, 22 Jul 2022 10:18:58 +0200, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote in

> > Which commits would we consider?
> >
> > 7170f2159fb2 Allow "in place" tablespaces.
> > f6f0db4d6240 Fix pg_tablespace_location() with in-place tablespaces
>
> The second one is just to make the function work with in-place
> tablespaces. Without it the function yeilds the following error.
>
> > ERROR: could not read symbolic link "pg_tblspc/16407": Invalid argument
>
> This looks actually odd but I think no need of back-patching because
> there's no actual user of the feature is not seen in our test suite.
> If we have a test that needs the feature in future, it would be enough
> to back-patch it then.

Actually, I found that the new test added by the fix in this thread does
depend on this being fixed, so I included an even larger set, which I
think makes this more complete:

7170f2159fb2 Allow "in place" tablespaces.
c6f2f01611d4 Fix pg_basebackup with in-place tablespaces.
f6f0db4d6240 Fix pg_tablespace_location() with in-place tablespaces
7a7cd84893e0 doc: Remove mention to in-place tablespaces for pg_tablespace_location()
5344723755bd Remove unnecessary Windows-specific basebackup code.

I didn't include any of the test changes for now. I don't intend to do
so, unless we see another reason for that; I think the new tests that
are going to be added by the recovery bugfix should be sufficient
coverage.

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"La fuerza no está en los medios físicos
sino que reside en una voluntad indomable" (Gandhi)