| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Erik Rijkers <er(at)xs4all(dot)nl> |
| Cc: | Pavel Stehule <pavel(dot)stehule(at)gmail(dot)com>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>, Joel Jacobson <joel(at)compiler(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Schema variables - new implementation for Postgres 15 |
| Date: | 2022-07-24 19:09:59 |
| Message-ID: | 20220724190959.GF7789@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi Erik,
On Sun, Jul 24, 2022 at 03:39:32PM +0200, Erik Rijkers wrote:
> Attached a few small text-changes.
When you send patches like this, could you rename them to something other than
*.patch and *.diff ?
Otherwise, cfbot tries to apply *only* your patches to master, which fails due
to missing the original patches that your changes are on top of, and makes it
look like the author's patch needs to be rebased.
http://cfbot.cputube.org/pavel-stehule.html - Apply patches: FAILED
Alternately, (especially if your patch fixes a bug), you can resend the
author's patches, rebased, as [1.patch, ..., N.patch] plus your changes as
N+1.patch. Then, cfbot tests your patches, and the author can easily review
and then integrate your changes. (This is especially nice if the patches
currently need to be rebased, and you can make the cfbot pass at the same time
as sending fixes).
Cheers,
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Noah Misch | 2022-07-24 19:10:17 | Re: fairywren hung in pg_basebackup tests |
| Previous Message | Heikki Linnakangas | 2022-07-24 18:22:02 | ReadRecentBuffer() is broken for local buffer |