Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, michael(at)paquier(dot)xyz, gurjeet(at)singh(dot)im, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
Date: 2022-07-22 22:33:59
Message-ID: 20220722223359.GB3998906@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Fri, Jul 22, 2022 at 02:56:22PM -0400, Tom Lane wrote:
> + /*
> + * If this is an interactive session, load any libraries that should be
> + * preloaded at backend start. Since those are determined by GUCs, this
> + * can't happen until GUC settings are complete, but we want it to happen
> + * during the initial transaction in case anything that requires database
> + * access needs to be done.
> + */
> + if (!bootstrap &&
> + !IsAutoVacuumWorkerProcess() &&
> + !IsBackgroundWorker &&
> + !am_walsender)
> + process_session_preload_libraries();

I worry that this will be easily missed when adding new types of
non-interactive sessions, but I can't claim to have a better idea.

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-22 22:44:04 Re: Unprivileged user can induce crash by using an SUSET param in PGOPTIONS
Previous Message Nathan Bossart 2022-07-22 22:25:16 Re: privileges for ALTER ROLE/DATABASE SET