Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.

From: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
To: amit(dot)kapila16(at)gmail(dot)com
Cc: smithpb2250(at)gmail(dot)com, michael(at)paquier(dot)xyz, vignesh21(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Refactor to make use of a common function for GetSubscriptionRelations and GetSubscriptionNotReadyRelations.
Date: 2022-07-22 06:30:39
Message-ID: 20220722.153039.93469534096346206.horikyota.ntt@gmail.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

At Fri, 22 Jul 2022 11:11:23 +0530, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com> wrote in
> Hmm, I think that sounds more complicated than what I expected. I
> suggest let's go with a simple idea of using a boolean not_ready which
> will decide whether to use the additional key to search. I feel we can
> extend it by using a bitmask or enum when we have a clear need for
> more states.

FWIW, I vote for (only_)not_ready after rading through the thread..

regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Andrey Lepikhov 2022-07-22 06:39:23 Re: Fast COPY FROM based on batch insert
Previous Message Michael Paquier 2022-07-22 06:23:45 Re: Strange failures on chipmunk