Re: [PATCH v1] eliminate duplicate code in table.c

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Junwang Zhao <zhjwpku(at)gmail(dot)com>
Cc: pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH v1] eliminate duplicate code in table.c
Date: 2022-07-21 12:18:24
Message-ID: 20220721121824.2tbsgjxqczzopncl@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2022-Jul-21, Junwang Zhao wrote:

> There are some duplicate code in table.c, add a static inline function
> to eliminate the duplicates.

Hmm, but see commit 2ed532ee8c47 about this kind of check. Perhaps we
should change these error messages to conform to the same message style.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"I love the Postgres community. It's all about doing things _properly_. :-)"
(David Garamond)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Dean Rasheed 2022-07-21 12:25:27 Re: [PATCH] Introduce array_shuffle() and array_sample()
Previous Message Bilal Yavuz 2022-07-21 12:16:33 Re: [RFC] building postgres with meson - v10