Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Amul Sul <sulamul(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: GetStandbyFlushRecPtr() : OUT param is not optional like elsewhere.
Date: 2022-07-20 13:36:16
Message-ID: 20220720133616.yc5qa3wo4i4vtwum@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hello

On 2022-Jul-20, Amul Sul wrote:

> If you look at GetFlushRecPtr() function the OUT parameter for
> TimeLineID is optional and this is not only one, see
> GetWalRcvFlushRecPtr(), GetXLogReplayRecPtr(), etc.
>
> I think we have missed that for GetStandbyFlushRecPtr(), to be
> inlined, we should change this as follow:

This is something we decide mostly on a case-by-case basis. There's no
fixed rule that all out params have to be optional.

If anything is improved by this change, let's see what it is.

--
Álvaro Herrera Breisgau, Deutschland — https://www.EnterpriseDB.com/

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-20 13:38:50 Re: pgsql: Default to hidden visibility for extension libraries where possi
Previous Message Tom Lane 2022-07-20 13:34:37 Re: Remove fls(), use pg_bitutils.h facilities instead?