Re: Add function to return backup_label and tablespace_map

From: Stephen Frost <sfrost(at)snowman(dot)net>
To: Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com>
Cc: David Steele <david(at)pgmasters(dot)net>, Julien Rouhaud <rjuju123(at)gmail(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, Nathan Bossart <nathandbossart(at)gmail(dot)com>
Subject: Re: Add function to return backup_label and tablespace_map
Date: 2022-07-15 15:17:24
Message-ID: 20220715151724.GC9030@tamriel.snowman.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greetings,

* Fujii Masao (masao(dot)fujii(at)oss(dot)nttdata(dot)com) wrote:
> On 2022/07/08 23:11, David Steele wrote:
> >Looks like I made that more complicated than it needed to be:
> >
> >select * from pg_backup_stop(...) \gset
> >\pset tuples_only on
> >\pset format unaligned
> >\o /backup_path/backup_label
> >select :'labelfile';
>
> Thanks! I had completely forgotten \gset command.

Seems like it might make sense to consider using a better format for
these files and also to allow us to more easily add things in the future
(ending LSN, ending time, etc) for backup tools to be able to leverage.
Perhaps we should change this to having just a single file returned,
instead of two, and use JSON for it, as a more general and extensible
format that we've already got code to work with..?

Thanks,

Stephen

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2022-07-15 15:56:41 Re: Adjust ndistinct for eqjoinsel
Previous Message Jelte Fennema 2022-07-15 14:59:55 Re: Support load balancing in libpq