Re: fix stats_fetch_consistency value in postgresql.conf.sample

From: Andres Freund <andres(at)anarazel(dot)de>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Justin Pryzby <pryzby(at)telsasoft(dot)com>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, nathandbossart(at)gmail(dot)com, pgsql-hackers(at)postgresql(dot)org
Subject: Re: fix stats_fetch_consistency value in postgresql.conf.sample
Date: 2022-07-13 23:49:00
Message-ID: 20220713234900.z4rniuaerkq34s4v@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

On 2022-07-14 08:46:02 +0900, Michael Paquier wrote:
> On Wed, Jul 13, 2022 at 12:30:00PM -0500, Justin Pryzby wrote:
> > How did you make this list ? Was it by excluding things that failed for you ?
> >
> > cfbot is currently failing due to io_concurrency on windows.
> > I think there are more GUC which should be included here.
> >
> > http://cfbot.cputube.org/kyotaro-horiguchi.html
>
> FWIW, I am not really a fan of making this test depend on a hardcoded
> list of GUCs.

I wonder if we should add flags indicating platform dependency etc to guc.c?
That should allow to remove most of them?

> The design strength of the existing test is that we
> don't have such a dependency now, making less to think about in terms
> of maintenance in the long-term, even if this is now run
> automatically.

There's no existing test for things covered by these exceptions, unless I am
missing something?

Greetings,

Andres Freund

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Justin Pryzby 2022-07-13 23:54:45 Re: fix stats_fetch_consistency value in postgresql.conf.sample
Previous Message Michael Paquier 2022-07-13 23:46:02 Re: fix stats_fetch_consistency value in postgresql.conf.sample