Re: pgsql: Add copy/equal support for XID lists

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: Re: pgsql: Add copy/equal support for XID lists
Date: 2022-07-12 18:35:16
Message-ID: 20220712183516.cmdowamk7eqahmjw@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-hackers

On 2022-Jul-12, Tom Lane wrote:

> What about outfuncs/readfuncs? I see that you fixed _outList,
> but not its caller outNode:
>
> else if (IsA(obj, List) || IsA(obj, IntList) || IsA(obj, OidList))
> _outList(str, obj);
>
> and the LEFT_PAREN case in nodeRead() doesn't know what to do either.

Hmm, true -- naively grepping for OidList wasn't enough (moreso when I
failed to notice one occurrence). This patch closes the holes you
mentioned. I haven't found any others yet.

--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"La vida es para el que se aventura"

Attachment Content-Type Size
0001-Fix-XID-list-support-some-more.patch text/x-diff 2.8 KB

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2022-07-12 19:17:54 pgsql: Remove trailing newlines in pg_upgrade's message strings.
Previous Message Larry Rosenman 2022-07-12 15:29:20 Re: pgsql: Fix out-of-bounds read in json_lex_string

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2022-07-12 18:47:07 Re: First draft of the PG 15 release notes
Previous Message Peter Eisentraut 2022-07-12 18:29:47 Re: Transparent column encryption