| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | DropRelFileLocatorBuffers |
| Date: | 2022-07-07 08:44:36 |
| Message-ID: | 20220707.174436.1885393789789795413.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hello.
While working on a patch, I met a function with the signature of:
> DropRelFileLocatorBuffers(SMgrRelation smgr_reln, ForkNumber *forkNum,
> int nforks, BlockNumber *firstDelBlock)
It was DropRelFileNodeBuffers(), which means "Drop buffers for a
RelFileNode", where RelFileNode means a storage or a (set of) file(s).
In that sense, "Drop buffers for a RelFile*Locator*" sounds a bit off
to me. Isn't it better change the name? RelFileLocator doesn't look
to be fit here.
"DropRelFileBuffers" works better at least for me.. If it does, some
other functions need the same amendment.
Thought?
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Pavel Borisov | 2022-07-07 08:50:00 | Re: Fix unnecessary includes and comments in 019_replslot_limit.pl, 007_wal.pl and 004_timeline_switch.pl |
| Previous Message | Kyotaro Horiguchi | 2022-07-07 08:32:33 | Re: Make mesage at end-of-recovery less scary. |