symbol "conflicts" between libpq and binaries

From: Andres Freund <andres(at)anarazel(dot)de>
To: pgsql-hackers(at)postgresql(dot)org
Subject: symbol "conflicts" between libpq and binaries
Date: 2022-07-05 20:47:15
Message-ID: 20220705204715.u6byzurpjeldjpan@awork3.anarazel.de
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

There's a number of symbols that are exported by libpq that are also in
binaries (mostly via pgport). That strikes me as not great, because the
behaviour in those cases isn't particularly well defined / OS dependent /
linker option dependent.

How about renaming those functions, turning the functions exported by libpq
into wrappers?

This is at least:

pqsignal
pg_char_to_encoding
pg_valid_server_encoding_id
pg_valid_server_encoding
pg_encoding_to_char
pg_utf_mblen

I'm not quite sure why we export some of these, but we likely don't want to
change that, given the API/ABI break that'd cause.

Greetings,

Andres Freund

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2022-07-05 21:02:37 Re: making relfilenodes 56 bits
Previous Message Robert Haas 2022-07-05 20:43:15 Re: making relfilenodes 56 bits