Re: Handle infinite recursion in logical replication setup

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: vignesh C <vignesh21(at)gmail(dot)com>
Cc: Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, "shiy(dot)fnst(at)fujitsu(dot)com" <shiy(dot)fnst(at)fujitsu(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, Ashutosh Bapat <ashutosh(dot)bapat(dot)oss(at)gmail(dot)com>, "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Handle infinite recursion in logical replication setup
Date: 2022-07-04 14:14:02
Message-ID: 20220704141402.wdjzpkcybeg4foqg@alvherre.pgsql
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> From d8f8844f877806527b6f3f45320b6ba55a8e3154 Mon Sep 17 00:00:00 2001
> From: Vigneshwaran C <vignesh21(at)gmail(dot)com>
> Date: Thu, 26 May 2022 19:29:33 +0530
> Subject: [PATCH v27 1/4] Add a missing test to verify only-local parameter in
> test_decoding plugin.
>
> Add a missing test to verify only-local parameter in test_decoding plugin.

I don't get it. replorigin.sql already has some lines to test
local-only. What is your patch adding that is new? Maybe instead of
adding some more lines at the end of the script, you should add lines
where this stuff is already being tested. But that assumes that there
is something new that is being tested; if so what is it?

--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
"Investigación es lo que hago cuando no sé lo que estoy haciendo"
(Wernher von Braun)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zhihong Yu 2022-07-04 14:16:31 Re: Removing unneeded self joins
Previous Message Aleksander Alekseev 2022-07-04 14:00:19 Re: [PATCH] Compression dictionaries for JSONB