| From: | Noah Misch <noah(at)leadboat(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Guillaume Lelarge <guillaume(at)lelarge(dot)info>, Benoit Lobréau <benoit(dot)lobreau(at)gmail(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>, "Dr(dot) Michael Meskes" <michael(dot)meskes(at)credativ(dot)com> |
| Subject: | Re: Probable memory leak with ECPG and AIX |
| Date: | 2022-07-03 03:43:46 |
| Message-ID: | 20220703034346.GC2378460@rfd.leadboat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Sat, Jul 02, 2022 at 11:37:08PM -0400, Tom Lane wrote:
> Noah Misch <noah(at)leadboat(dot)com> writes:
> > Thanks for reviewing. Pushed with that comment. prairiedog complains[1]:
> > ld: common symbols not allowed with MH_DYLIB output format with the -multi_module option
> > connect.o definition of common _ecpg_clocale (size 4)
>
> Blah.
>
> > I bet this would fix it:
>
> > -locale_t ecpg_clocale;
> > +locale_t ecpg_clocale = (locale_t) 0;
>
> Hmm, I was considering suggesting that just on stylistic grounds,
> but decided it was too nitpicky even for me.
> Do you want me to test it on prairiedog?
Sure, if it's easy enough. If not, I'm 87% sure it will suffice.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-07-03 03:45:04 | Re: Probable memory leak with ECPG and AIX |
| Previous Message | Tom Lane | 2022-07-03 03:37:08 | Re: Probable memory leak with ECPG and AIX |