Re: minor change for create_list_bounds()

From: Nathan Bossart <nathandbossart(at)gmail(dot)com>
To: Zhihong Yu <zyu(at)yugabyte(dot)com>
Cc: PostgreSQL Developers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: minor change for create_list_bounds()
Date: 2022-06-29 23:41:01
Message-ID: 20220629234101.GA364747@nathanxps13
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On Tue, Mar 08, 2022 at 11:05:10AM -0800, Zhihong Yu wrote:
> I was looking at commit db632fbca and noticed that,
> in create_list_bounds(), if index is added to boundinfo->interleaved_parts
> in the first if statement, there is no need to perform the second check
> involving call to partition_bound_accepts_nulls().

Given this change probably doesn't meaningfully impact performance or code
clarity, I'm personally -1 for this patch. Is there another motivation
that I am missing?

--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jonathan S. Katz 2022-06-30 00:41:23 Re: PostgreSQL 15 beta 2 release announcement draft
Previous Message Nathan Bossart 2022-06-29 23:19:39 Re: replacing role-level NOINHERIT with a grant-level option