| From: | Andres Freund <andres(at)anarazel(dot)de> |
|---|---|
| To: | "Bagga, Rishu" <bagrishu(at)amazon(dot)com> |
| Cc: | "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: SLRUs in the main buffer pool - Page Header definitions |
| Date: | 2022-06-24 01:06:48 |
| Message-ID: | 20220624010648.6eb6i4cwvkr5f4sb@alap3.anarazel.de |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi,
On 2022-06-24 00:39:41 +0000, Bagga, Rishu wrote:
> >When do we need to do so? We should never need to figure out whether an
> >on-disk block is for an SLRU or something else, without also knowing >which
> >relation / SLRU it is in.
>
> You are correct that we wouldn’t need to rely on the pd_flag bit to
> determine page type for any access to a page where we come top down
> following the hierarchy. However, for the purpose of debugging “from the
> bottom up” it would be critical to know what type of page is being read in a
> system with multiple page header types.
That doesn't seem to justify using a bit on the page. Wouldn't it suffice to
add such information to the BufferDesc?
Greetings,
Andres Freund
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2022-06-24 01:43:07 | Re: Race condition in TransactionIdIsInProgress |
| Previous Message | Bagga, Rishu | 2022-06-24 00:39:41 | Re: SLRUs in the main buffer pool - Page Header definitions |