| From: | Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> |
|---|---|
| To: | alvherre(at)alvh(dot)no-ip(dot)org |
| Cc: | daniele(dot)varrazzo(at)gmail(dot)com, pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages |
| Date: | 2022-06-10 06:33:36 |
| Message-ID: | 20220610.153336.1737348584200945579.horikyota.ntt@gmail.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
At Fri, 10 Jun 2022 15:25:44 +0900 (JST), Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com> wrote in
> The current implement of PQsendQueryInternal looks like the result of
> a misunderstanding of the doc. In the regression tests, that path is
> excercised only for an error case, where no CloseComplete comes.
>
> The attached adds a test for the normal-path of pipelined
> PQsendQuery() to simple_pipeline test then modifies that function not
> to send Close message. Without the fix, the test fails by "unexpected
> notice" even if the trace matches the "expected" content.
And, as a matter of course, this fix should be back-patched to 14.
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2022-06-10 13:51:27 | Re: BUG #17515: Change in behaviour of a composite type within a domain |
| Previous Message | Kyotaro Horiguchi | 2022-06-10 06:25:44 | Re: Using PQexecQuery in pipeline mode produces unexpected Close messages |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2022-06-10 06:36:38 | Re: better page-level checksums |
| Previous Message | Amit Kapila | 2022-06-10 06:26:57 | Re: Support logical replication of DDLs |