| From: | Justin Pryzby <pryzby(at)telsasoft(dot)com> |
|---|---|
| To: | Peter Smith <smithpb2250(at)gmail(dot)com> |
| Cc: | Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, houzj(dot)fnst(at)fujitsu(dot)com, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>, pgsql-hackers(at)lists(dot)postgresql(dot)org, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: bogus: logical replication rows/cols combinations |
| Date: | 2022-06-08 03:25:21 |
| Message-ID: | 20220608032521.GM29853@telsasoft.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Mon, Jun 06, 2022 at 03:42:31PM +1000, Peter Smith wrote:
> I noticed the patch "0001-language-fixes-on-HEAD-from-Justin.patch" says:
>
> @@ -11673,7 +11673,7 @@
> prosrc => 'pg_show_replication_origin_status' },
>
> # publications
> -{ oid => '6119', descr => 'get information of tables in a publication',
> +{ oid => '6119', descr => 'get information about tables in a publication',
>
> ~~~
>
> But, this grammar website [1] says:
...
> From which I guess
>
> 1. 'get information of tables in a publication' ~= 'get information
> belonging to tables in a publication'
But the information doesn't "belong to" the tables.
The information is "regarding" the tables (or "associated with" or "concerned
with" or "respecting" or "on the subject of" the tables).
I think my change is correct based on the grammar definition, as well as its
intuitive "feel".
--
Justin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kyotaro Horiguchi | 2022-06-08 04:06:25 | Re: Error from the foreign RDBMS on a foreign table I have no privilege on |
| Previous Message | Kyotaro Horiguchi | 2022-06-08 03:09:27 | Re: Error from the foreign RDBMS on a foreign table I have no privilege on |