| From: | Nathan Bossart <nathandbossart(at)gmail(dot)com> |
|---|---|
| To: | "Thibaud W(dot)" <thibaud(dot)walkowiak(at)dalibo(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | Re: Proposal: adding a better description in psql command about large objects |
| Date: | 2022-06-03 14:39:21 |
| Message-ID: | 20220603143921.GA2624579@nathanxps13 |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On Fri, Jun 03, 2022 at 10:12:30AM +0200, Thibaud W. wrote:
> In fact the original tabs were missing in the first file.
> In version v2, it seems interesting to keep calls to the fprintf function
> for translation. I attached a new file.
Yes, it looks like the precedent is to have an fprintf() per command. I
still think the indentation needs some adjustment for readability. In the
attached, I've lined up all the large object commands. This is offset from
most other commands, but IMO this is far easier to read, and something
similar was done for the operator class/family commands. Thoughts?
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
| Attachment | Content-Type | Size |
|---|---|---|
| v4-0001-Add-descriptions-for-psql-s-large-object-backslas.patch | text/x-diff | 1.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Daniel Gustafsson | 2022-06-03 14:52:09 | Re: [v15 beta] pg_upgrade failed if earlier executed with -c switch |
| Previous Message | Tom Lane | 2022-06-03 14:04:12 | Re: [PATCH] Expose port->authn_id to extensions and triggers |